He is popular --- all --- his goodness.

Answer: 
with, for
He is popular --- all --- his goodness.